Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotplug fixes #1616

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Hotplug fixes #1616

merged 1 commit into from
Jan 23, 2025

Conversation

SiegeLord
Copy link
Member

Do a pass on joystick hotplugging.

  • MacOS wasn't reusing joystick slots
  • Linux was getting duplicate joysticks due to reading from
    /dev/input/by-path
  • Windows XInput wasn't re-initializing joystick names
  • SDL was completely broken

Also, I redid ex_joystick_hotplugging to be more useful/exciting.

See #1533

@pedro-w
Copy link
Contributor

pedro-w commented Jan 16, 2025

Not a big deal but some of the changed files don't seem to be related to this. (unless they are in some subtle way!)

Also, I redid ex_joystick_hotplugging to be more useful/exciting.

👍👍👍👍👍

@SiegeLord
Copy link
Member Author

SiegeLord commented Jan 17, 2025

Not a big deal but some of the changed files don't seem to be related to this. (unless they are in some subtle way!)

Maybe you're referring to the files changed by the first commit, which is in separate PR #1612. Github still has no way to do chained PRs, it seems.

@SiegeLord SiegeLord mentioned this pull request Jan 10, 2025
5 tasks
@pedro-w
Copy link
Contributor

pedro-w commented Jan 17, 2025

Maybe you're referring to the files changed by the first commit, which is in separate PR #1612.

Yes, that's right. There are changes to files in acodec for example. I just wanted to check that it wasn't some unrelated update that had got dragged into this PR.

@SiegeLord
Copy link
Member Author

Those changes are from the other PR: since the new joystick API is unstable, a bunch of files which incidentally include joysticks need to define the internal unstable macro... it's very annoying, I wish for a better solution.

- MacOS wasn't reusing joystick slots
- Linux was getting duplicate joysticks due to reading from
  /dev/input/by-path
- Windows XInput wasn't re-initializing joystick names
- SDL was completely broken

Also, I redid ex_joystick_hotplugging to be more useful/exciting.

See liballeg#1533
@SiegeLord SiegeLord merged commit 539db57 into liballeg:master Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants