demo.css: fix demo options not shown on Chrome #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome doesn't allow changing the background color of the <option> but it allows changing the text color. As a result, the text was white on a white background. Since Firefox allows background styling, the <option> background is standardized to white so it works the same in Firefox.
|
Please merge this in! Would be a very good fix to have! Thanks. |
This was referenced Jun 5, 2019
AJLoveChina
approved these changes
Dec 13, 2019
|
Why not merge this pull request? This css issue makes it very difficult for users to use. @liabru |
|
For now 2019-12-13, this issue is still open, |
|
Thanks for raising, I know it's been forever but this is now merged and will be in the next release along with some other improvements. |
This was referenced Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome doesn't allow changing the background color of the
but it allows changing the text color.
As a result, the text was white on a white background.
Since Firefox allows background styling, the
background is standardized to white so it works the
same in Firefox.
Before on Chrome:
Before on Firefox:
After on Chrome and Firefox:
PS: the newline at the end of the file was created by the Github editor, feel free to remove it