Improve Matter.Runner #1254
Merged
Improve Matter.Runner #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2023
|
This change would be highly appreciated, is there something I can do to help merge it? |
* master: (22 commits) improve test comparison report update ci update ci preserve pair.contacts order optimised Resolver.solvePosition bump package lock improve test comparison report fixed compare tool layer order in demo testbed fixed compare tool layer order in demo testbed added multi example testing tool to demo added body removal to Example.remove changed Composte.removeComposite and Composte.removeBody to reset body.sleepCounter optimised Collision.collides fix collision events for sleeping pairs, closes #1077 added local pairs functions in Pairs.update removed pair.confirmedActive changed Pair.id format to use shorter ids optimised Resolver.solveVelocity optimised contacts and supports memory and gc use optimised pairs and collisions memory and gc use ...
|
Agreed with @davidreis97, we really would like to see this merged, and maybe some examples to demonstrate how this will fix issues associated with nondeterminism, and monitor framerates differing |
|
Hi @liabru , are there any updates on the viability of getting this merged? |
Merged
|
This is now released as of 0.20.0, thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds built-in
Matter.Runnersupport for:As before
Matter.Runneris still optional and a starting point for learning and developing with the engine. These changes should generally not affect those using their own runner or otherwise callingEngine.updatedirectly.Usage
If you wish to try these beta changes out in your environment before release:
runner.delta(see docs andExample.substep)These features are still experimental and helpful feedback on your results is welcome.
There may be some further changes to come on this PR before a general release is possible.
Changes
Matter.Runnerrunner.delta)runner.isFixed)runner.maxFrameTimeandrunner.maxUpdateswindow.requestAnimationFramepolyfillsMatter.Renderrender.options.showDebugMigration
Matter.Runnernow defaults to a fixed deterministic timestep (support for non-fixed is removed)runner.deltaand appropriaterunner.maxFrameTimeandrunner.maxUpdates(see docs)Matter.Runnercan call zero, one, or multiple engine updates and events per display frameMatter.Runnerupdated docs throughoutwindow.requestAnimationFrameRelated
#5, #500, #652, #702, #818, #820, #885, #971, #1152, #1164, #1167