Changing devices in Fbank #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomiinek
commented
Mar 16, 2023
Comment on lines
+79
to
+81
| def to(self, device: str): | ||
| self.config.device = device | ||
| self.extractor.to(device) |
There was a problem hiding this comment.
Because I would like to instantiate multiple extractors on different devices via .from_yaml(...) and using the same config file.
Tomiinek
commented
Mar 16, 2023
| @@ -385,7 +389,6 @@ def _extract_batch( | |||
| samples = [samples.reshape(1, -1)] | |||
|
|
|||
| if any(isinstance(x, torch.Tensor) for x in samples): | |||
| samples = [x.numpy() for x in samples] | |||
There was a problem hiding this comment.
This seems to be useless. It fails for CUDA tensors and the numpy arrays are converted to tensors three lines below anyway.
There was a problem hiding this comment.
I think that a usecase where the user inputs a list of mixture of numpy arrays and tensors is paranoid 😄
Tomiinek
commented
Mar 16, 2023
| @@ -403,7 +406,9 @@ def _extract_batch( | |||
| samples = torch.nn.utils.rnn.pad_sequence(samples, batch_first=True) | |||
|
|
|||
| # Perform feature extraction | |||
| feats = extractor(samples.to(device)).cpu() | |||
There was a problem hiding this comment.
Since I would expect the output tensor to be on the same device as the input tensor .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.