himia dataset #991
Merged
himia dataset #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2023 14:33
pzelasko
previously approved these changes
Mar 8, 2023
lhotse/recipes/himia.py
Outdated
| output_dir = Path(output_dir) | ||
| output_dir.mkdir(parents=True, exist_ok=True) | ||
| manifests = defaultdict(dict) | ||
| train_dev_dataset_parts = ["train", "dev", "test", "cw_test"] |
There was a problem hiding this comment.
You might want to follow how eg LibriSpeech recipe does auto-discovery of the available parts in case somebody only needs a subset.
There was a problem hiding this comment.
Updated according to your comments. Hope for your further reviews.
added 2 commits
March 9, 2023 21:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am building a wake word recipe in icefall for this dataset.
Hope for your review for this data preparation part. @pzelasko