-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the download function of commonvoice command line interface #968
Conversation
I see you closed it, but I'd be happy to merge if you want to finish the PR. |
When I run this command,pre-commit run, I got an error. stderr:
Check the log at /Users/lishaojie/.cache/pre-commit/pre-commit.log |
I have solved it by modify the isort version in the pre-commit configuration file, 5.10.1-->5.12.0,I will resubmit a pr later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I left a few more comments to clean up the code before merging.
lhotse/recipes/commonvoice.py
Outdated
@@ -30,7 +30,9 @@ | |||
) | |||
|
|||
DEFAULT_COMMONVOICE_URL = "https://voice-prod-bundler-ee1969a6ce8178826482b88e843c335139bd3fb4.s3.amazonaws.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the deprecated URL here?
Thanks! |
When the version is less than 8.0, CommonVoice requires you to enter e-mail to download the data.
Or you can choose a version greater than 8.0.