Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the download function of commonvoice command line interface #968

Merged
merged 6 commits into from
Feb 19, 2023

Conversation

manbaaaa
Copy link
Contributor

@manbaaaa manbaaaa commented Feb 7, 2023

When the version is less than 8.0, CommonVoice requires you to enter e-mail to download the data.
Or you can choose a version greater than 8.0.

@manbaaaa manbaaaa closed this Feb 7, 2023
@pzelasko
Copy link
Collaborator

pzelasko commented Feb 7, 2023

I see you closed it, but I'd be happy to merge if you want to finish the PR.

@manbaaaa manbaaaa reopened this Feb 8, 2023
@manbaaaa
Copy link
Contributor Author

manbaaaa commented Feb 8, 2023

When I run this command,pre-commit run, I got an error.
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/Users/lishaojie/.cache/pre-commit/repo0867tdpc/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
Processing /Users/lishaojie/.cache/pre-commit/repo0867tdpc
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'done'
Preparing metadata (pyproject.toml): started
Preparing metadata (pyproject.toml): finished with status 'error'

stderr:
error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      Traceback (most recent call last):
        File "/Users/lishaojie/.cache/pre-commit/repo0867tdpc/py_env-python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/Users/lishaojie/.cache/pre-commit/repo0867tdpc/py_env-python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/Users/lishaojie/.cache/pre-commit/repo0867tdpc/py_env-python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
        File "/private/var/folders/1c/b41cgr692j54pvc6psgv4bp40000gn/T/pip-build-env-pqepxcm_/overlay/lib/python3.7/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
          poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
        File "/private/var/folders/1c/b41cgr692j54pvc6psgv4bp40000gn/T/pip-build-env-pqepxcm_/overlay/lib/python3.7/site-packages/poetry/core/factory.py", line 57, in create_poetry
          raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
      
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Check the log at /Users/lishaojie/.cache/pre-commit/pre-commit.log

@manbaaaa
Copy link
Contributor Author

manbaaaa commented Feb 9, 2023

I have solved it by modify the isort version in the pre-commit configuration file, 5.10.1-->5.12.0,I will resubmit a pr later.

Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left a few more comments to clean up the code before merging.

@@ -30,7 +30,9 @@
)

DEFAULT_COMMONVOICE_URL = "https://voice-prod-bundler-ee1969a6ce8178826482b88e843c335139bd3fb4.s3.amazonaws.com"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the deprecated URL here?

lhotse/recipes/commonvoice.py Outdated Show resolved Hide resolved
lhotse/recipes/commonvoice.py Outdated Show resolved Hide resolved
@pzelasko pzelasko merged commit cf3a57b into lhotse-speech:master Feb 19, 2023
@pzelasko
Copy link
Collaborator

Thanks!

@pzelasko pzelasko added this to the v1.13 milestone Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants