Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in trim_to_supervision_groups + tolerance for overspans #963

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Bug in trim_to_supervision_groups + tolerance for overspans #963

merged 4 commits into from
Feb 1, 2023

Conversation

desh2608
Copy link
Collaborator

@desh2608 desh2608 commented Jan 31, 2023 •
edited
Loading

  • Fixed bug and added edge case as test.
  • Add a small epsilon in the floating point comparison in overspans.

@desh2608 desh2608 added the bug Something isn't working label Jan 31, 2023
@desh2608 desh2608 changed the title Fix bug in trim_to_supervision_groups [WIP] Fix bug in trim_to_supervision_groups Jan 31, 2023
@desh2608 desh2608 changed the title [WIP] Fix bug in trim_to_supervision_groups Fix bug in trim_to_supervision_groups Feb 1, 2023
@desh2608 desh2608 requested a review from pzelasko February 1, 2023 01:22
@desh2608 desh2608 changed the title Fix bug in trim_to_supervision_groups Bug in trim_to_supervision_groups + tolerance for overspans Feb 1, 2023
pzelasko
pzelasko reviewed Feb 1, 2023
View reviewed changes
test/cut/test_cut_trim_to_supervisions.py
Scenario::


■───────────────────Recording───────────────────────■
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy!

pzelasko
pzelasko approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pzelasko pzelasko merged commit 35c5e57 into lhotse-speech:master Feb 1, 2023
@pzelasko pzelasko added this to the v1.13 milestone Feb 1, 2023
@desh2608 desh2608 deleted the bug/cut_pause branch November 2, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
2 participants
@desh2608 @pzelasko