Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor update for recipes.utils.read_manifests_if_cached #932

Merged
merged 3 commits into from
Jan 2, 2023
Merged

minor update for recipes.utils.read_manifests_if_cached #932

merged 3 commits into from
Jan 2, 2023

Conversation

trunglebka
Copy link
Contributor

Fixes: #910

@trunglebka trunglebka closed this Dec 24, 2022
@trunglebka trunglebka reopened this Dec 24, 2022
@trunglebka
Copy link
Contributor Author

trunglebka commented Dec 26, 2022 •
edited
Loading

Look like unit tests failed due to numpy deprecated numpy.float: https://stackoverflow.com/questions/74844262/how-to-solve-error-numpy-has-no-attribute-float-in-python

@pzelasko pzelasko added this to the v1.12 milestone Jan 2, 2023
@pzelasko
Copy link
Collaborator

pzelasko commented Jan 2, 2023

Thanks, I fixed it in #936, I'll merge once the tests pass.

@pzelasko pzelasko merged commit 6ff9575 into lhotse-speech:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Add type checking for dataset_parts param of recipes.utils.read_manifests_if_cached
2 participants
@trunglebka @pzelasko