Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloading the AMI dataset using CLI will trigger TypeError #919

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Downloading the AMI dataset using CLI will trigger TypeError #919

merged 2 commits into from
Dec 9, 2022

Conversation

JinZr
Copy link
Contributor

@JinZr JinZr commented Dec 9, 2022

Using the wrong keyword when calling the "download_ami" function triggers this error:

TypeError: download_ami() got an unexpected keyword argument 'annotations_dir'

JinZr added 2 commits December 10, 2022 00:38
@JinZr
Fixed an error which triggers "TypeError"
8b39a66 
Fixed an error which triggers "TypeError" while downloading AMI dataset
@JinZr
Merge pull request #1 from JinZr/JinZr-patch-1
bca1ebe 
Fixed an error which triggers "TypeError"
pzelasko
pzelasko approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pzelasko pzelasko merged commit 1a2d084 into lhotse-speech:master Dec 9, 2022
@pzelasko pzelasko added this to the v1.12 milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
2 participants
@JinZr @pzelasko