Add xbmu amdo31 #902
Add xbmu amdo31 #902
Conversation
| @@ -59,3 +59,4 @@ | |||
| from .voxceleb import * | |||
| from .wenet_speech import * | |||
| from .yesno import * | |||
| from .xbmu_amdo31 import * | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Also, please sort the import alphabetically, i.e.,
from .xbmu_amdo31 import *
from .yesno import *
| @@ -0,0 +1,126 @@ | |||
| """ | |||
| About the XBMU-AMDO31 corpus | |||
| XBMU-AMDO31 is an open-source Amdo Tibetan speech corpus published by Northwest Minzu University. | |||
There was a problem hiding this comment.
Could you add some more details about the corpus? It seems the HF link does not contain any description either. You can refer to the other recipes.
There was a problem hiding this comment.
Ok, HF will update today with more descriptions and add more details to this part of the code.
lhotse/recipes/xbmu_amdo31.py
Outdated
| """ | ||
| Downdload and untar the dataset | ||
| :param target_dir: Pathlike, the path of the dir to storage the dataset. | ||
| :param force_download: Bool, if True, download the tars no matter if the tars exist. |
There was a problem hiding this comment.
The force_download and base_url arguments are not present in the function definition.
There was a problem hiding this comment.
This part of the code will be updated today or tomorrow, and the downloadable corpus code in icefall will be removed and added to lhotse.
| :param base_url: str, the url of the OpenSLR resources. | ||
| :return: the path to downloaded and extracted directory with data. | ||
| """ | ||
| target_dir = Path(target_dir) |
There was a problem hiding this comment.
It seems here you are assuming that a tar.gz file is already downloaded in the target_dir? If so, please add some message here in case these are not present. For example, does the user need to download these files manually?
lhotse/recipes/xbmu_amdo31.py
Outdated
|
|
||
| manifests[part] = {"recordings": recording_set, "supervisions": supervision_set} | ||
|
|
||
| return manifests |
There was a problem hiding this comment.
Probably should have a newline at end of file to avoid flake8 error.
There was a problem hiding this comment.
Thanks for the reminder
|
Is it good to merge? @desh2608 |
|
LGTM. @sendream are you planning to make more changes or should I merge? |
Hi, no more changes, you should merge. |
No description provided.