load ark directly in KaldiReader #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
commented
Oct 25, 2022
| @@ -582,8 +582,6 @@ class FeatureSet(Serializable, AlgorithmMixin): | |||
|
|
|||
| def __init__(self, features: List[Features] = None) -> None: | |||
| self.features = ifnone(features, []) | |||
| if isinstance(self.features, list): | |||
There was a problem hiding this comment.
I remove this sort since it causes errors when creating cutset using lhotse cut simple with features, supervisions, and recordings imported from kaldi.
csukuangfj
commented
Oct 25, 2022
| self.storage = kaldi_native_io.RandomAccessFloatMatrixReader( | ||
| f"scp:{self.storage_path}" | ||
| ) | ||
| if storage_path.endswith(".scp"): |
There was a problem hiding this comment.
This is for backward compatibility.
|
sorry for late response -- yes, most of it was already covered by tests.
y.
…On Tue, Oct 25, 2022 at 11:25 PM Piotr Żelasko ***@***.***> wrote:
Merged #862 <#862> into
master.
—
Reply to this email directly, view it on GitHub
<#862 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUKYXZOZNDC55TL3E2DMJ3WFCQBBANCNFSM6AAAAAAROEPP3E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.