Allow retaining or trimming channels in trim_to_supervisions #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
reviewed
Oct 12, 2022
lhotse/cut/base.py
Outdated
| @@ -394,6 +394,7 @@ def trim_to_supervisions( | |||
| keep_overlapping: bool = True, | |||
| min_duration: Optional[Seconds] = None, | |||
| context_direction: Literal["center", "left", "right", "random"] = "center", | |||
| ignore_channel: bool = False, | |||
There was a problem hiding this comment.
What do you think about keep_all_channels: bool = False? ignore_channel is a little vague for me, but I'm not sure.
There was a problem hiding this comment.
Yeah, that seems reasonable. I'll change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider AMI IHM as an example. For each session, we create a multi-cut with 4 channels (1 channel per speaker), and each supervision segment corresponds to one of the 4 channels (based on who the speaker is). If we then want to use this data to train an ASR system, we can call
trim_to_supervisions(). Currently, the resulting cuts would still contain 4 channels. This PR allows the user to trim the channels to the supervisions (by default), or ignore channel while trimming.