-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiCut
to store multi-channel recordings with shared supervision
#822
Conversation
… feature/multi_channel_sup
…o feature/multi_channel_sup
…o feature/multi_channel_sup
…08/lhotse into feature/multi_channel_sup
MultiCut
to store multi-channel recordings with shared supervisionMultiCut
to store multi-channel recordings with shared supervision
I think this one's ready for review once the tests pass. |
The visualization looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, very impressive work!! I left just a few comments, mostly minor ones + asking for a bit more test coverage, otherwise it looks great!
@pzelasko Addressed all comments. |
LGTM! Again, great work. |
This PR adds a
MultiCut
which is a new type of Cut that represents multi-channel data. We also define aDataCut
as a Cut which contains actual data (as opposed to a PaddingCut or MixedCut which are empty or operations on other cuts). This DataCut is the abstract base class from which MonoCut and MultiCut inherit.