Add pad_silence option to extend_by
#816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
previously approved these changes
Sep 22, 2022
Yeah, I suppose that makes sense. I'll make the change. (It might be worth explicitly pointing out this change in behavior in the next release's changelog, in case others are using the method. I know I am using it in one of my projects.) |
pzelasko
approved these changes
Sep 22, 2022
|
The unit test fail is a random flake, merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address #779.
Currently, the
extend_by()method only extends the cut to at most the boundaries of the recording. With this option set to true, we can now pad with silence to extend beyond the recording's boundaries.