Fix import namespaces

[pzelasko]

Closes #697

[jtrmal]

Would you mind changing the xfail "import" test in kaldi import/export tests and checking if it gets also resolved?
I think it fails for the same reasons

[jtrmal]

Specifically

lhotse/test/test_kaldi_dirs.py

Line 168 in cda63b5

@pytest.mark.xfail(reason="Import ordering is somehow not working for now")

[pzelasko]

It failed with

============================= test session starts ==============================
collecting ... collected 1 item

test/test_kaldi_dirs.py::test_get_duration_failurex FAILED               [100%]
test/test_kaldi_dirs.py:167 (test_get_duration_failurex)
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x113fdc160>

    def test_get_duration_failurex(monkeypatch):
        def always_fail_is_module_available(path):
            return False
    
>       monkeypatch.setattr(
            lhotse.utils.is_module_available, always_fail_is_module_available
        )
E       TypeError: use setattr(target, name, value) or setattr(target, value) with target being a dotted import string

test/test_kaldi_dirs.py:172: TypeError

No idea what to do with it.

[jtrmal]

ok, that I think resolved the import issue and now I just have to learn how to write a correct test ;) y.

…

On Thu, May 5, 2022 at 11:16 AM Piotr Żelasko ***@***.***> wrote: It failed with ============================= test session starts ============================== collecting ... collected 1 item test/test_kaldi_dirs.py::test_get_duration_failurex FAILED [100%] test/test_kaldi_dirs.py:167 (test_get_duration_failurex) monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x113fdc160> def test_get_duration_failurex(monkeypatch): def always_fail_is_module_available(path): return False > monkeypatch.setattr( lhotse.utils.is_module_available, always_fail_is_module_available ) E TypeError: use setattr(target, name, value) or setattr(target, value) with target being a dotted import string test/test_kaldi_dirs.py:172: TypeError No idea what to do with it. — Reply to this email directly, view it on GitHub <#698 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACUKYX4X7MLK4BOGER4FK63VIPQ5XANCNFSM5VFLBKAA> . You are receiving this because you commented.Message ID: ***@***.***>

[jtrmal]

I consider it my issue to fix, so perhaps do not worry about it. y.

…

On Thu, May 5, 2022 at 11:18 AM Jan Yenda Trmal ***@***.***> wrote: ok, that I think resolved the import issue and now I just have to learn how to write a correct test ;) y. On Thu, May 5, 2022 at 11:16 AM Piotr Żelasko ***@***.***> wrote: > It failed with > > ============================= test session starts ============================== > collecting ... collected 1 item > > test/test_kaldi_dirs.py::test_get_duration_failurex FAILED [100%] > test/test_kaldi_dirs.py:167 (test_get_duration_failurex) > monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x113fdc160> > > def test_get_duration_failurex(monkeypatch): > def always_fail_is_module_available(path): > return False > > > monkeypatch.setattr( > lhotse.utils.is_module_available, always_fail_is_module_available > ) > E TypeError: use setattr(target, name, value) or setattr(target, value) with target being a dotted import string > > test/test_kaldi_dirs.py:172: TypeError > > No idea what to do with it. > > — > Reply to this email directly, view it on GitHub > <#698 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACUKYX4X7MLK4BOGER4FK63VIPQ5XANCNFSM5VFLBKAA> > . > You are receiving this because you commented.Message ID: > ***@***.***> >