Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] fisher_english recipe #1410

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[fix] fisher_english recipe #1410

merged 1 commit into from
Oct 23, 2024

Conversation

pengzhendong
Copy link
Contributor

@pengzhendong pengzhendong commented Oct 23, 2024 •
edited
Loading

The paths returned by parent.iterdir() contain parent.

>>> p = Path('docs')
>>> for child in p.iterdir(): child

PosixPath('docs/conf.py')
PosixPath('docs/Makefile')

pzelasko
pzelasko approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pzelasko pzelasko merged commit 8b6d6f5 into lhotse-speech:master Oct 23, 2024
9 checks passed
@pzelasko pzelasko added this to the v1.28.0 milestone Oct 23, 2024
@pengzhendong pengzhendong deleted the patch-2 branch October 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pengzhendong @pzelasko