Added has_custom to MixedCut #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
previously approved these changes
Aug 8, 2024
anteju
force-pushed
the
pr/mixedcut-has-custom
branch
from
888a43f to
b704c2d
Compare
Signed-off-by: Ante Jukić <[email protected]>
anteju
force-pushed
the
pr/mixedcut-has-custom
branch
from
b704c2d to
1054836
Compare
pzelasko
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
MixedCutis not resolvinghas_customcorrectly.This caused problems in
collate_audiowhen usingMixedCutwithrecording_field != None, which would fail herehttps://github.com/lhotse-speech/lhotse/blob/master/lhotse/dataset/collation.py#L175
with something like
This PR adds
has_customtoMixedCutand a brief unit test.