-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent Speech Commands dataset, SLU task #1272
Conversation
Thanks! Please remove the code that’s commented out. Can you also update the table in |
Done! How do things look now? |
lhotse/recipes/slu.py
Outdated
from pathlib import Path | ||
from typing import Dict, List, NamedTuple, Optional, Tuple, Union | ||
|
||
import pandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move pandas (and ideally also soundfile) into the local import scope so that importing this file does not trigger a hard requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed in the latest commit! (Turns out soundfile was not used at all)
Head branch was pushed to by a user without write access
Is there anything I can do with the two unit tests that failed? The 3.10 failure seems to be the pytest runner having had a random issue. With regards to the codecov/project one, do I need to write a pytest for my recipe? |
Don’t worry about these tests — they are flaky and I need to fix them separately. Codecov is just for info and not needed to pass. LGTM! |
Related Icefall PR: k2-fsa/icefall#1469
Dataset link: https://fluent.ai/fluent-speech-commands-a-dataset-for-spoken-language-understanding-research/
Thanks!