update_recipes #1208
Merged
update_recipes #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- commonvoice : use "spawn" context in `ProcessPoolExecutor` - eval2000 : bugfix (@click.option must begin with `--*`) - librispeech : add `--to-lowercase` for librispeech dataprep (default are uppercase transcripts)
KarelVesely84
force-pushed
the
update_recipes
branch
from
a8569e1 to
e67ea29
Compare
desh2608
reviewed
Nov 6, 2023
Comment on lines
37
to
42
| @click.option( | ||
| "--to-lowercase", | ||
| type=bool, | ||
| default=False, | ||
| help="Conversion of transcripts to lower-vase (originally in uppercase).", | ||
| ) |
There was a problem hiding this comment.
@vesis84 most other recipes have an option called --normalize-text with choices such as "upper", "kaldi", etc. Maybe you can name this option the same for consistency?
KarelVesely84
force-pushed
the
update_recipes
branch
2 times, most recently
from
b8124a4 to
ed03ca7
Compare
|
Hi, thanks @desh2608 for the suggestion. Now, it is refactored accordingly ( and tested ). |
desh2608
reviewed
Nov 7, 2023
| "--normalize-text", | ||
| type=click.Choice(["none", "lower"], case_sensitive=False), | ||
| default="none", | ||
| help="Conversion of transcripts to lower-vase (originally in uppercase).", |
There was a problem hiding this comment.
lower-vase --> lower-case
There was a problem hiding this comment.
ok, corrected now...
… as desh2608 suggested
KarelVesely84
force-pushed
the
update_recipes
branch
from
ed03ca7 to
ae2518b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing small changes to the recipes:
ProcessPoolExecutor--*)--to-lowercasefor librispeech dataprep (default are uppercase transcripts)