Fix for trim_to_alignments issue
#1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
reviewed
Oct 18, 2023
| @@ -363,15 +363,15 @@ def test_cut_trim_to_supervisions_keep_overlapping_extend(mono_cut): | |||
| # Extended on the right side only by (4.0 - 3.37) / 2 == 0.315; | |||
| # the left side is capped by the start of the recording. | |||
| assert len(c1.supervisions) == 1 | |||
| assert c1.start == 0.0 | |||
| assert c1.start == 1.0 | |||
There was a problem hiding this comment.
After changing the mono_cut fixture, this test case no longer represents the illustrated scenario. Also the comment above seems to be in conflict with the test outcome (looks like c1 should have 4 seconds now that it's not capped by the start of the recording anymore)
There was a problem hiding this comment.
Good point. I'll fix the tests tomorrow.
There was a problem hiding this comment.
Sorry I lost track of this. Have made the appropriate changes now --- should not affect the older tests.
pzelasko
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1186
The key issue was that in a couple of places, we did not account for the fact that start time of
AlignmentItemis w.r.t. the start of the recording, whereas that forSupervisionSegmentis w.r.t. the Cut.with_offsetfunction for the supervision, alignment start times do not change, since they are w.r.t. the recording.