Support export_to_kaldi on resampled recordings
#1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sih4sing5hong5
changed the title
pzelasko
changed the title
export_to_kaldi on resampled recordings
|
Can you fix the checks? |
OK |
auto-merge was automatically disabled
September 26, 2023 12:34
Head branch was pushed to by a user without write access
I fixed the isort and black :) |
pzelasko
approved these changes
Sep 27, 2023
flyingleafe
pushed a commit
to flyingleafe/lhotse
that referenced
this pull request
Oct 11, 2023
* Add the test. * fixed the test. * Pass the transforms into function because the resample function will modify the transforms. * Modified other tests. * black * isort --------- Co-authored-by: Piotr Żelasko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
When the 8kHz wav recording resampled to 16kHz was exported to kaldi_dir, the
wav.scpshould containffmpeg -ar 16000.Expectation
There is parameter about 16kHz in
wav.scpResult
Only the file path.