Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whisper feature extractor #1159

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Add whisper feature extractor #1159

merged 4 commits into from
Sep 22, 2023

Conversation

yuekaizhang
Copy link
Contributor

No description provided.

@yuekaizhang
Copy link
Contributor Author

@pzelasko Hi Piotr, I add a whisper feature extractor to better support whisper fine-tuning with lhotse. Would you mind checking it please? Thanks.

pzelasko
pzelasko reviewed Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Can you add a unit test to cover this extractor? You can look either at test/features/*.py or test/cut/test_feature_extraction.py for starting points.

@pzelasko pzelasko added this to the v1.17 milestone Sep 21, 2023
@yuekaizhang
Copy link
Contributor Author

Thanks, looks good! Can you add a unit test to cover this extractor? You can look either at test/features/*.py or test/cut/test_feature_extraction.py for starting points.

Done.

pzelasko
pzelasko approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pzelasko pzelasko enabled auto-merge (squash) September 22, 2023 02:48
@pzelasko pzelasko merged commit 3875788 into lhotse-speech:master Sep 22, 2023
flyingleafe pushed a commit to flyingleafe/lhotse that referenced this pull request Oct 11, 2023
@yuekaizhang @flyingleafe
Add whisper feature extractor (lhotse-speech#1159)
858f2e9 
* add whisper feature extractor

* hard coding config

* add test for whisper feature extractor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csukuangfj csukuangfj csukuangfj left review comments

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
3 participants
@yuekaizhang @csukuangfj @pzelasko