MixedCut.truncate
: fix the case when only PaddingCut
s are left
#1157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered another couple of bugs after simulating long conversations with
ConversationalMeetingSimulator
, cutting them into windows and loading the windows' audios:PaddingCut
was returned for which the audio (zeros array) could not be loaded, sincenum_samples
property was not defined;PaddingCut
s remained after truncation, this case was not properly handled (in the same way as "no cuts remained" case), which resulted in theIndexError
exception at the last lines oftruncate
method (where we attempt to set SNR of first non-padding track toNone
)This PR fixes those.