Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2046b55 introduced a silly yet horrible regression, completely breaking down
save_audio
method:MixedCut
s, since they do not haverecording
field, sofastcopy
fails there;DataCut
s as well, sincefastcopy
preserved the original start times of the cut, while the underlying recording had changed, and so every such cut became invalid aftersave_audio
(except maybe for the one starting from the very beginning of the original recording.I do not have time today to add regression test for this, maybe tomorrow.
This amounted to my almost entire working day being completely puzzled about why my data preparation pipeline got completely broken after I just changed the underlying data.... been blaming the data itself initially, not the
master
update.(Basically, I did some
.cut_into_windows
+.padding
+.filter
and then.save_audios
)