making the kaldi import more robust #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Piotr, what would you think about this change ? (I found this issue while importing per-utterance flac files for Chime challenge) |
pzelasko
reviewed
Aug 23, 2023
lhotse/kaldi.py
Outdated
| durations = dict(zip(recordings.keys(), dur_vals)) | ||
|
|
||
| # remove recordings with 'None' duration (i.e. there was a read error) | ||
| for recording_id, duration in durations.items(): | ||
| if durations == None: |
There was a problem hiding this comment.
Suggested change
| if durations == None: | |
| if duration is None: |
csukuangfj
reviewed
Aug 23, 2023
lhotse/kaldi.py
Outdated
| logging.warning( | ||
| f"[{recording_id}] Could not get duration. " | ||
| f"Failed to read audio from `{recordings[recording_id]}`. " | ||
| f"Dropping the recording from manifest." |
There was a problem hiding this comment.
Suggested change
| f"Dropping the recording from manifest." | |
| "Dropping the recording from manifest." |
lhotse/kaldi.py
Outdated
| durations = dict(zip(recordings.keys(), dur_vals)) | ||
|
|
||
| # remove recordings with 'None' duration (i.e. there was a read error) | ||
| for recording_id, dur_value in durations.items(): | ||
| if dur_value == None: |
There was a problem hiding this comment.
To fix the style issue, we can use
if dur_value is None:
to replace
if dur_value == None:
get_duration(): - recover if audio file cannot be loaded for get_duration(), drop such recordings... - use chunksize for ProcessPoolExecutor::map (avoid hanging of ProcessPoolExecutor for large RecordingSets)
KarelVesely84
force-pushed
the
kaldi_import_get_duration
branch
from
087c5ef to
4c1f3cf
Compare
|
Ok, both suggested changes are done. I also added a new sanity check... |
- not more than 20% utterances can be dropped on `kaldi import`
KarelVesely84
force-pushed
the
kaldi_import_get_duration
branch
from
4c1f3cf to
c70b20b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_duration():