Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix_manifests in all recipes #1128

Merged
merged 30 commits into from
Aug 24, 2023
Merged

Add fix_manifests in all recipes #1128

merged 30 commits into from
Aug 24, 2023

Conversation

desh2608
Copy link
Collaborator

In my experience, most issues in cut manipulations arise because of some issues in the source supervisions (e.g., some supervisions exceeding recording duration). This can be fixed easily using the fix_manifests method.

desh2608 added 29 commits April 20, 2023 11:26
@desh2608
add transform attribute for MixedCut
ce0f5c1
@desh2608
add mix_first option in normalize_loudness
ab18682
@desh2608
handle the case when mix is called on MixedCut with existing transforms
e4bca74
@desh2608
add test for mixing with transformed MixedCut
71a9236
@desh2608
enhancements and bug fixes
2e54646
@desh2608
small changes in some cutset methods
db37a75
@desh2608
small fix in error message
7b59ecd
@desh2608
return word alignments from ami recipe
a64727a
@desh2608
add word alignments for ICSI
850ce2c
@desh2608
remove unwanted whitespace
4b39c6f
@desh2608
fix IHM preparation
3c16b90
@desh2608
remove words with zero or negative duration
9921575
@desh2608
ensure word alignments respect segment boundary
dba413f
@desh2608
add save-to-wav option for icsi
12be424
@desh2608
add test for mixing cut with recording
c4b957d
@desh2608
Merge branch 'ami_icsi'
04ca4aa
@desh2608
Merge branch 'cuts'
fef3aa3
@desh2608
Merge branch 'mixed_cut_transform'
0de443e
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
80619bb
@desh2608
style fix
752be69
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
5bd483d
@desh2608
Merge branch 'loudness_fix'
68f3ffd
@desh2608
add data prep for voxpopuli
2171d7e
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
df32e5c
@desh2608
Merge branch 'recipe/voxpopuli'
67c9223
@desh2608
fix merge conflicts
0e36e3f
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse
399834b
@desh2608
Merge branch 'master' of https://github.com/lhotse-speech/lhotse into…
71ed2e1 
… fix_manifests
@desh2608
add fix_manifests for all recipes
c4fe1c9
@desh2608 desh2608 requested a review from pzelasko August 24, 2023 11:47
pzelasko
pzelasko approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through all of the recipes!

@pzelasko pzelasko enabled auto-merge (squash) August 24, 2023 14:02
@pzelasko pzelasko added this to the v1.17 milestone Aug 24, 2023
@pzelasko pzelasko merged commit 6914818 into lhotse-speech:master Aug 24, 2023
@desh2608 desh2608 deleted the fix_manifests branch August 24, 2023 14:54
@desh2608 desh2608 mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
2 participants
@desh2608 @pzelasko