Minor bug fix for eval2000 recipe

[JinZr]

No description provided.

[desh2608]

I don't think the transcription corpus always contains that subdirectory? I think that may be particular to your setup.

[desh2608]

It may be useful to provide a transcript_dir option to the function, which defaults to the original path. Users can provide a different path based on how their corpus is set up.

[JinZr]

Dear Desh, Sounds good, I implemented this in the latest commit.

…

On Wed, Aug 23, 2023 at 11:49 PM Desh Raj ***@***.***> wrote: It may be useful to provide a transcript_dir option to the function, which defaults to the original path. Users can provide a different path based on how their corpus is set up. — Reply to this email directly, view it on GitHub <#1127 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOON42BIU5BHDMO2MOHMUVLXWYRB3ANCNFSM6AAAAAA33S2YF4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[JinZr]

Thanks Desh, the latest commit should fix this issue.

…

On Fri, Aug 25, 2023 at 9:22 PM Desh Raj ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lhotse/bin/modes/recipes/eval2000.py <#1127 (comment)> : > @prepare.command(context_settings=dict(show_default=True)) @click.argument("corpus-dir", type=click.Path(exists=True, file_okay=False)) @click.argument("output-dir", type=click.Path()) ***@***.***( Have you tested this with and without providing transcript-dir? It seems you are expecting this to be a positional argument which may not be what we want. ------------------------------ In lhotse/recipes/eval2000.py <#1127 (comment)> : > @@ -29,6 +29,7 @@ def prepare_eval2000( corpus_dir: Pathlike, output_dir: Pathlike, + transcript_path: Pathlike, ⬇️ Suggested change - transcript_path: Pathlike, + transcript_path: Optional[Pathlike] = None, ------------------------------ In lhotse/recipes/eval2000.py <#1127 (comment)> : > @@ -48,7 +49,7 @@ def prepare_eval2000( assert ( audio_partition_dir_path.is_dir() ), f"No such directory:{audio_partition_dir_path}" - transcript_dir_path = corpus_dir / EVAL2000_TRANSCRIPT_DIR / "reference" / "english" + transcript_dir_path = transcript_path ⬇️ Suggested change - transcript_dir_path = transcript_path + default_transcript_path = corpus_dir / EVAL2000_TRANSCRIPT_DIR / "reference" / "english" + transcript_dir_path = default_transcript_path if transcript_path is None else transcript_path — Reply to this email directly, view it on GitHub <#1127 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOON42EQEF2OUTHD7RIB2X3XXCRIRANCNFSM6AAAAAA33S2YF4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pzelasko]

Thanks!