Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some additional options for supervision-related methods #1115

Merged
merged 38 commits into from
Aug 11, 2023

Conversation

desh2608
Copy link
Collaborator

@desh2608 desh2608 commented Aug 3, 2023

This PR adds some options that may be useful in manipulating supervisions/cuts, such as:

  • CLI method for SupervisionSet.with_alignment_from_ctm()
  • max_segment_duration option in CutSet.trim_to_alignments() to control the length of segments
  • merge_policy option in merge_supervisions() --> this allows either concatenating with a delimiter (default), or using the first supervision's value.

I will add test cases for these.

desh2608 added 30 commits April 20, 2023 11:26
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I left a couple of comments.

lhotse/cut/mono.py Outdated Show resolved Hide resolved
lhotse/cut/base.py Outdated Show resolved Hide resolved
lhotse/cut/base.py Outdated Show resolved Hide resolved
lhotse/cut/base.py Outdated Show resolved Hide resolved
lhotse/cut/base.py Outdated Show resolved Hide resolved
@desh2608 desh2608 changed the title [WIP] Some additional options for supervision-related methods Some additional options for supervision-related methods Aug 11, 2023
@desh2608 desh2608 enabled auto-merge (squash) August 11, 2023 19:09
@desh2608 desh2608 requested a review from pzelasko August 11, 2023 19:10
@desh2608 desh2608 added this to the v1.16 milestone Aug 11, 2023
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desh2608 desh2608 merged commit aa073f6 into lhotse-speech:master Aug 11, 2023
@desh2608 desh2608 deleted the sups/alignment branch August 11, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants