[Recipe] VoxPopuli #1089
Merged
[Recipe] VoxPopuli #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
reviewed
Jul 17, 2023
lhotse/recipes/voxpopuli.py
Outdated
| import torch | ||
| import torchaudio | ||
| from torch.hub import download_url_to_file | ||
| from torchaudio.datasets.utils import _extract_tar |
There was a problem hiding this comment.
this fails in CI but I think we have our own util for that (lhotse.utils.safe_extract)
|
IMO LGTM after fixing and if somebody wants to add s2s mode later, they can add it. |
Yeah, I am already using the ASR prep part for some of the projects at JSALT. I like our method more than the official data preparation since it does not duplicate all the segments. I will fix the extract and then maybe we can merge. |
pzelasko
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.