Fix bugs in MixedCut logic
#1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case which would have failed before this change but is fixed now? |
|
@desh2608 yes, added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to simulate some conversations, then cut them into windows and save the resulting cuts on the disk. I have encountered two bugs:
IndexErrorinMixedCut.truncate: happened because the cut window happened to be in the region betweenMixTracks, so no intersecting tracks were found and such case was not handled;AssertionErrorinMixedCut.load_audio: the resulting audio length were mismatched, because the offset of the first track in the cut was not accounted for during mixing, resulting in incorrect mix length.This PR fixes those:
PaddingCutin the first case;