Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance TIMIT recipe #1072

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

flyingleafe
Copy link
Contributor

@flyingleafe flyingleafe commented May 25, 2023

  • Actually touch .completed detector file to avoid re-downloading
  • Actually use multiple processes during preparation when num_jobs > 1
  • Fix the paths to audio files and transcriptions in the unpacked folder (add data subdirectory)
  • Use full text as transcription on SupervisionSegment level; add word and phoneme transcriptions as alignment layers.
  • Provide info about speaker's gender explicitly to SupervisionSegment
  • Better progress reporting via tqdm

@pzelasko
Copy link
Collaborator

@luomingshuang could you take a look? I think you were building the Icefall recipe for TIMIT, would be great if you checked this PR doesn't break it.

@luomingshuang
Copy link
Contributor

Ok, I will have a check for it.

@flyingleafe flyingleafe force-pushed the better-timit-recipe branch 2 times, most recently from 6de8484 to f3cb8ce Compare June 2, 2023 06:41
@flyingleafe
Copy link
Contributor Author

@luomingshuang bump, all good?

@flyingleafe flyingleafe force-pushed the better-timit-recipe branch from f3cb8ce to ba3a71f Compare June 12, 2023 06:22
@desh2608
Copy link
Collaborator

@luomingshuang do you think this is good to merge?

@luomingshuang
Copy link
Contributor

I am having a check for it.

@luomingshuang
Copy link
Contributor

Well, I think this PR is ready to MERGE. It adds some functions for alignment.

Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @flyingleafe and for the help in reviewing @luomingshuang!

@pzelasko pzelasko enabled auto-merge (squash) August 4, 2023 01:38
@pzelasko pzelasko added this to the v1.16 milestone Aug 4, 2023
@pzelasko pzelasko merged commit eb9e6b1 into lhotse-speech:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants