Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air Traffic Control (ATC) corpora - various improvements #1070

Conversation

rouseabout
Copy link
Contributor

Thanks for merging the ATC recipes! Here are the additional patches from my branch that I didn't get around to pushing:

  • safe_extract_rar unit test
  • atcosim: pandas module availability check
  • atcosim: apply fix to supervision durations (fixes the first problem reported in Supervision and feature frame size mismatch #1064)
  • uwb_atcc: sort file names before processing to ensure reproducibility
  • resumable_download: add optional completed_file_size argument
  • atcosim,uwb_atcc: call resumable_download with completed file size

@pzelasko pzelasko enabled auto-merge (squash) May 24, 2023 11:57
pzelasko
pzelasko previously approved these changes May 24, 2023
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM once all CI checks pass.

Do not bother downloading file if the file size on disk matches the
complete_file_size argument. This saves http request when file is already
downloaded or stored on read-only file system.
auto-merge was automatically disabled May 24, 2023 22:33

Head branch was pushed to by a user without write access

@rouseabout rouseabout force-pushed the air-traffic-control-corpora-various-improvements branch from 718e567 to 6fbf7c1 Compare May 24, 2023 22:33
@pzelasko pzelasko enabled auto-merge (squash) May 26, 2023 18:35
@pzelasko pzelasko merged commit 3071ade into lhotse-speech:master May 26, 2023
@pzelasko pzelasko added this to the v1.15 milestone May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants