Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support preparing almost all NSC data part except PART3_SameBoundaryMic #1066

Merged
merged 7 commits into from
May 26, 2023
Merged

Support preparing almost all NSC data part except PART3_SameBoundaryMic #1066

merged 7 commits into from
May 26, 2023

Conversation

trunglebka
Copy link
Contributor

@trunglebka trunglebka commented May 22, 2023 •
edited
Loading

This PR contains:

  • Support preparing almost all NSC data part except PART3_SameBoundaryMic
  • Support process parallelly for PART1, PART2

Limit:

  • All was manually verified, (but I've done some minor update before making PR and processing take time so...)
  • My English is not good, so wording may contain grammar error, please correct me.

pzelasko
pzelasko reviewed May 23, 2023
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please change the type annotations to Union[a, b], older python versions do not support the | syntax for types. In general LGTM after the unit tests are passing.

@trunglebka
Copy link
Contributor Author

trunglebka commented May 24, 2023 •
edited
Loading

@pzelasko Done

@pzelasko pzelasko added this to the v1.15 milestone May 24, 2023
@pzelasko pzelasko enabled auto-merge (squash) May 24, 2023 02:31
auto-merge was automatically disabled May 26, 2023 02:33

Head branch was pushed to by a user without write access

@pzelasko pzelasko enabled auto-merge (squash) May 26, 2023 18:48
@pzelasko pzelasko merged commit 4ecbb02 into lhotse-speech:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.
2 participants
@trunglebka @pzelasko