Small changes in some cut methods #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
desh2608
commented
May 16, 2023
desh2608
commented
- When trimming to supervision groups, give sensible ids instead of completely randomized.
- Progress bar for exporting to Shar.
- Minor fix in error message.
- Fix for trim_to_supervisions #1034.
pzelasko
reviewed
May 22, 2023
| def test_mix_cut_with_other_raises_error(libri_cut): | ||
| libri_cut = libri_cut.drop_features() | ||
| with pytest.raises(ValueError): | ||
| _ = libri_cut.mix(libri_cut.recording) |
There was a problem hiding this comment.
why is this test supposed to fail? because of drop features or because the argument to mix is of type Recording?
There was a problem hiding this comment.
The latter. We cannot mix a Cut with a Recording. (The drop_features() is just to ensure that it does not fail earlier when checking for features in the mixed_in cut.)
pzelasko
approved these changes
May 22, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.