Integrate torchaudio's 2.0 ffmpeg backend for audio loading + add some optimizations #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out when we enable ffmpeg backend it seems to slightly modify the audio when saving to WAVE (by up to 2/int16max), so I modified some tests to work around it and filed an issue in torchaudio pytorch/audio#3281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for in-memory data with file-like objects, I found ffmpeg FLAC decoder to be twice as fast as that of libsoundfile.
Note: enabling this feature with pytorch/torchaudio 2.0 requires setting of the following environment variable:
TORCHAUDIO_USE_BACKEND_DISPATCHER=1, and this shouldn't be necessary anymore starting with version 2.1