Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure RIR has same sampling rate as audio #1037

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Ensure RIR has same sampling rate as audio #1037

merged 2 commits into from
Apr 21, 2023

Conversation

desh2608
Copy link
Collaborator

Fix for #1036.

@desh2608 desh2608 linked an issue Apr 21, 2023 that may be closed by this pull request
Unused sample rate in ReverbWithImpulseResponse #1036
Closed
@desh2608
Copy link
Collaborator Author

Actually I think it may be better to check the sampling rate at the time of calling reverb_rir(), since at the time of load_audio() it may have gotten modified by a resampling operation. @pzelasko does this sound correct?

@pzelasko
Copy link
Collaborator

Yes I think you're right. If the sampling rates are matching at the time of calling reverb_rir, it will be safe to apply it.

@pzelasko pzelasko merged commit 3c621b5 into lhotse-speech:master Apr 21, 2023
@pzelasko pzelasko added this to the v1.14 milestone Apr 21, 2023
@pzelasko
Copy link
Collaborator

Thanks!

@desh2608 desh2608 deleted the rir_sampling_rate branch April 21, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

Unused sample rate in ReverbWithImpulseResponse
2 participants
@desh2608 @pzelasko