Fix bug in lazy CutSet subset with last #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
reviewed
Apr 7, 2023
lhotse/cut/set.py
Outdated
| @@ -996,8 +996,7 @@ def subset( | |||
| f"CutSet has only {len(self)} items but last {last} required; not doing anything." | |||
| ) | |||
| return self | |||
| cut_ids = list(self.ids)[-last:] | |||
| return CutSet.from_cuts(self[cid] for cid in cut_ids) | |||
| return CutSet.from_cuts(islice(self, len(self) - last, len(self))) | |||
There was a problem hiding this comment.
Can you assign len(self) to a variable to avoid double iteration for lazy cut sets?
pzelasko
approved these changes
Apr 10, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was raised in #1018 (reply in thread).