Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor bug in conversational meeting simulation algorithm #1007

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Fix minor bug in conversational meeting simulation algorithm #1007

merged 2 commits into from
Mar 22, 2023

Conversation

desh2608
Copy link
Collaborator

  • We use add_durations to make the start/end times of mixed in segments more precise.
  • There was a minor bug earlier which was causing 3-fold overlaps even when set to False. This is fixed now.

pzelasko
pzelasko approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@pzelasko pzelasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pzelasko pzelasko added this to the v1.13 milestone Mar 22, 2023
@pzelasko pzelasko merged commit 5a6bc65 into lhotse-speech:master Mar 22, 2023
@desh2608 desh2608 deleted the workflow/sim branch November 2, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko pzelasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
2 participants
@desh2608 @pzelasko