(cut|recording).dereverb_wpe() API + more stable numpy version
#1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
reviewed
Mar 17, 2023
lhotse/augmentation/wpe.py
Outdated
|
|
||
| from nara_wpe.wpe import wpe_v8 | ||
|
|
||
| assert audio.ndim == 2 |
There was a problem hiding this comment.
Shall we print out audio.shape on assertion failure?
csukuangfj
reviewed
Mar 17, 2023
|
|
||
| def reverse_timestamps( | ||
| self, offset: Seconds, duration: Optional[Seconds], sampling_rate: int | ||
| ) -> Tuple[Seconds, Optional[Seconds]]: | ||
| return offset, duration | ||
|
|
||
|
|
||
| def dereverb_wpe_numpy( |
There was a problem hiding this comment.
This function is not documented at all.
csukuangfj
reviewed
Mar 17, 2023
lhotse/testing/dummies.py
Outdated
| @@ -80,31 +80,46 @@ def dummy_recording( | |||
| def dummy_audio_source( | |||
| num_samples: int = 16000, | |||
| sampling_rate: int = 16000, | |||
| channels: List[int] = None, | |||
There was a problem hiding this comment.
Should it be Optional[List[int]]?
|
Thanks for the review, I fixed everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @boeddeker for the suggestion.