Neovim and Tmux improvements #34

nandalopes · 2021-07-12T19:44:07Z

style(nvim): group together colorschemes
feat(nvim): allow local plugins
fix(nvim): powerline extended symbols
feat(nvim): OS specific keymaps
style(nvim): align comments on plugin set
refactor(tmux): many improvements

Neovim and LightLine colorschemes in the same file

- Highlight window name with purple bold when zoomed - Renumber windows - Separate colorscheme from other styling settings - Use `none` instead of `nobold,noitalic,...` - Restore clear screen keybind mapped over by tmux-navigator

lfilho

Hey! Thanks for the contribution!! 💪

Apart the questions/comments I posted on the diff view, it looks likes there's a some new things, other things being changed, but you haven't documented / explained them here in the PR description. That alongside the several changes in indentation, spaces and styles, makes it really hard to review the PR.

I'd personally recommend not to change styles like that unless we can make it as part of automatic linting/tooling, otherwise it becomes a matter of personal taste (then next person sending a PR will change it to something THEY like, so on so on...).

If you insist on changing the style, at least comment on each diff what is actually changing / new versus just style changes.

lfilho · 2021-07-14T03:14:07Z

nvim/plugins/improvements.vim

@@ -1,37 +1,36 @@
-


The diff is hard to parse now. Is this just changing some of the order the comments' indentation?

Unless there's a plugin automatically indenting the comments like this, I would prefer to leave as they were before otherwise it would be tiresome to keep maintaining and changing spacing around them. So could you please either provide that auto-formatting support or keep the previous commenting style? Thanks!

Yes there is Tabular, in improvements bundle

But is not automatically formatting the file, right?

No, it's not like an autocmd, but can be easily triggered using the plugin included (Tabularize)

Exactly, that's my point: if we don't have an automatic way to guarantee formatting, better not to change it. Otherwise here's what happens:

There's one personal cosmetic preference currently (mine)

You send a big diff with your own personal preference (this PR)

From now on me and future contributors have to adjust and remember to use Tabularize in those files (extra annoying manual work)

A future contributor don't like your personal preference from step 2 and sends a big PR to either revert it back to the way it was on step 1 or worse, proposes a 3rd way 😓

The cycle repeats, including this very conversation 😄

It's 2021, styling/formatting shouldn't be done manually. If there's not a way to make the auto-formatting work or if it's not worth the effort, then the recommendation when contributing to an existing project is to leave as it is when you found and follow the repo's current style in order to avoid unnecessary diffs and discussions around personal preferences. Makes sense?

lfilho · 2021-07-14T03:16:27Z

nvim/plugins/main.vim

@@ -19,4 +19,10 @@ for fpath in split(globpath(pluginPath, '*.vim'), '\n')
  endif
 endfor

+" The plugins listed in ~/.config/nvim/.local.vim will be added here to


We already support this. Check the the before/main and after/main files. The comments in there explain it. nvim/README also documents and explains this...

It's intended to local plugin aditions, not after and before settings overrides.

But we actually can install custom plugins in the current after files, right? So my question is why do we need a second way of accomplishing that..?

No we don't, unless we add another .vim in plugins folder, and that file will be tracked anyway.

What I mean is that we can add a Plug install <bla> in the after file and it would work to install plugins, wouldn't it?
Also, it's best to let the author of a comment resolve that thread instead of resolving it ourselves 😇

Hmm have you actually tested it? I have just tested it and it works:

created ~/.yadr/nvim/settings/after/test.vim

added Plug 'pineapplegiant/spaceduck', { 'branch': 'main' } in it (it's a colorscheme)

ran :PlugInstall

ran :colors spaceduck

Worked, without the test.vim being tracked

Maybe you missed this?

dotfiles/.gitignore

Lines 18 to 21 in 50db8ba

nvim/settings/before/*.vim

!nvim/settings/before/main.vim

nvim/settings/after/*.vim

!nvim/settings/after/main.vim

It trackes the */main.vim in those folders, without tracking any other *.vims in them...

It installs the plugin, but it doesn't get loaded after restarting nvim:

Erro detectado ao processar /home/nanda/.dotfiles/neovim/settings/after/colorscheme.vim: linha 10: E185: Esquema de cores 'spaceduck' não encontrado

Adendum: it's not necessary to explicit load .local.vim on plugins/main.vim, but is mandatory to load Plug there, otherwise you won't get the plugin after restarting nvim.

Yes, that's correct. That's the default behavior. Upon installing we do manually trigger Plug so it can install the plugins, though. Anything post-install needs to have an explicit call to PlugInstall.

But I'm confused why you brought that up, that would also happen with your proposed changes, right?

nvim/settings/plugin-lightline.vim

tmux/tmux.conf

nvim/settings/vim-keymaps-linux.vim

.gitignore

nvim/settings/after/colorscheme.vim

nvim/settings/main.vim

tmux/tmux.conf

nandalopes

I'm sorry for this mono-PR. I comment on commits the changes.

.gitignore

nvim/settings/after/colorscheme.vim

nandalopes · 2021-07-14T04:30:09Z

nvim/plugins/main.vim

@@ -19,4 +19,10 @@ for fpath in split(globpath(pluginPath, '*.vim'), '\n')
  endif
 endfor

+" The plugins listed in ~/.config/nvim/.local.vim will be added here to


It's intended to local plugin aditions, not after and before settings overrides.

nvim/settings/plugin-lightline.vim

tmux/tmux.conf

nvim/settings/main.vim

nandalopes · 2021-07-15T12:18:16Z

Tmux improvements:

Highlight window name with purple bold font when zoomed
Renumber windows
Separate colorscheme from other styling settings
Use none style attribute instead of nobold,noitalic,...
Restore clear screen keybind mapped over by tmux-navigator
- C-l changes pane
- Prefix + C-l clear screen

Neovim improvements:

Use nerdfonts powerline glyphs
Source local plugins commands at plugins/main.vim, before plug#end()

This reverts commit 30fb18f.

Put your {name-of-local-bundle}.vim on plugins folder, your plugin will be loaded across program restarts

lfilho · 2021-08-02T18:33:13Z

.gitignore

@@ -19,3 +19,5 @@ nvim/settings/before/*.vim
 !nvim/settings/before/main.vim
 nvim/settings/after/*.vim
 !nvim/settings/after/main.vim
+nvim/plugins/*.vim


This can't be here: it will make all current files in there not be tracked by git anymore. So if we change any configuration, or add a new plugin and configuration file later on, it wouldn't be picked up by git. Only the before and after files should be here, because only those ones are supposed to be untracked by git (things users can add post install to their liking)

I think this is the only remaining thing in the PR, otherwise it's looking good! Thanks!!

Actually git remains aware of changes in files that are already added.
Any change in the files on repo will be noticed, only tools that use .gitignore patterns to exclude search will be affected, like ripgrep without --no-vcs-ignore opt.

Yes, but what if we want to add a new plugin (e.g.: right now i have a coc branch and in the future i might merge it in, in that case the new files in there wouldn't get tracked and my changes would stay local to my machine)?

What benefits did you have in mind by adding this here? I am not seeing them yet, only the issue i highlight above :)

For example, at work I manage some PHP files, but I don't want to add a PHP bundle on personal computer.

At home I use vimwiki, but not at work., and so on.

I have a work branch, which I've forced add a web.vim bundle, with git add -f <file>, and a local_bundles.vim file at home, not tracked, with vimwiki.

Got it. I still don't see a big reason to do it, but I guess it doesn't hurt to try. Will merge. Thanks again for the nice contributions! I'm about to push some more as well

nandalopes added 7 commits July 12, 2021 16:24

style(nvim): group together colorschemes

25bbff2

Neovim and LightLine colorschemes in the same file

feat(nvim): allow local plugins

2091781

fix(nvim): powerline extended symbols

cdfc09b

feat(nvim): OS specific keymaps

07d34b8

style(nvim): align comments on plugin set

30fb18f

refactor(tmux): many improvements

0862e06

- Highlight window name with purple bold when zoomed - Renumber windows - Separate colorscheme from other styling settings - Use `none` instead of `nobold,noitalic,...` - Restore clear screen keybind mapped over by tmux-navigator

fix colorscheme

e88ecc0

lfilho requested changes Jul 14, 2021

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

nvim/settings/after/colorscheme.vim Show resolved Hide resolved

nvim/settings/main.vim Show resolved Hide resolved

tmux/tmux.conf Show resolved Hide resolved

fix(nvim): restore previous order of plugins

5c02dea

nandalopes commented Jul 14, 2021

View reviewed changes

nandalopes requested a review from lfilho July 15, 2021 00:41

nandalopes added 2 commits July 22, 2021 09:26

Revert "style(nvim): align comments on plugin set"

aabcf26

This reverts commit 30fb18f.

feat(nvim): allow adding local plugins

5a1ad34

Put your {name-of-local-bundle}.vim on plugins folder, your plugin will be loaded across program restarts

lfilho requested changes Aug 2, 2021

View reviewed changes

lfilho merged commit 744bfe3 into lfilho:master Aug 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Neovim and Tmux improvements #34

Neovim and Tmux improvements #34

nandalopes commented Jul 12, 2021

lfilho left a comment

lfilho Jul 14, 2021 •

edited

Loading

lfilho Jul 20, 2021

nandalopes Jul 20, 2021

lfilho Jul 21, 2021

nandalopes Jul 21, 2021

lfilho Jul 22, 2021

lfilho Jul 14, 2021

nandalopes Jul 14, 2021

lfilho Jul 17, 2021

nandalopes Jul 17, 2021

lfilho Jul 20, 2021

lfilho Jul 22, 2021

lfilho Jul 22, 2021 •

edited

Loading

nandalopes Jul 22, 2021

nandalopes Jul 22, 2021

lfilho Aug 2, 2021

nandalopes left a comment

nandalopes Jul 14, 2021

nandalopes commented Jul 15, 2021

lfilho Aug 2, 2021

nandalopes Aug 3, 2021

lfilho Aug 6, 2021

nandalopes Aug 6, 2021

lfilho Aug 8, 2021

	nvim/settings/before/*.vim
	!nvim/settings/before/main.vim
	nvim/settings/after/*.vim
	!nvim/settings/after/main.vim

Neovim and Tmux improvements #34

Neovim and Tmux improvements #34

Conversation

nandalopes commented Jul 12, 2021

lfilho left a comment

Choose a reason for hiding this comment

lfilho Jul 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lfilho Jul 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nandalopes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nandalopes commented Jul 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lfilho Jul 14, 2021 •

edited

Loading

lfilho Jul 22, 2021 •

edited

Loading