Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support event inc window state #3446

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 16, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer marked this pull request as draft December 16, 2024 05:53
@Yisaer Yisaer marked this pull request as ready for review December 16, 2024 05:57
Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 57.50000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 71.33%. Comparing base (b15cd40) to head (8516042).

Files with missing lines Patch % Lines
internal/topo/node/window_inc_agg_event_op.go 57.50% 30 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3446      +/-   ##
==========================================
- Coverage   71.39%   71.33%   -0.06%     
==========================================
  Files         412      412              
  Lines       47275    47336      +61     
==========================================
+ Hits        33751    33764      +13     
- Misses      10893    10932      +39     
- Partials     2631     2640       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer marked this pull request as draft December 16, 2024 06:51
@Yisaer Yisaer marked this pull request as ready for review December 17, 2024 03:41
Signed-off-by: Song Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant