Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support io metrics #3443

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat: support io metrics #3443

merged 2 commits into from
Jan 6, 2025

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 13, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 31.11111% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.28%. Comparing base (1ebc3ae) to head (14460c7).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
extensions/impl/kafka/sink.go 0.00% 22 Missing ⚠️
extensions/impl/sql/sink.go 38.46% 7 Missing and 1 partial ⚠️
extensions/impl/kafka/source.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
- Coverage   71.34%   71.28%   -0.06%     
==========================================
  Files         412      414       +2     
  Lines       47154    47749     +595     
==========================================
+ Hits        33640    34034     +394     
- Misses      10886    11051     +165     
- Partials     2628     2664      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying
Copy link
Collaborator

Looks like these are common metrics. No need to add them in the specific io node. So close for now.

@ngjaying ngjaying closed this Dec 19, 2024
@Yisaer Yisaer reopened this Jan 3, 2025
@Yisaer Yisaer requested a review from ngjaying January 3, 2025 05:11
extensions/impl/kafka/sink.go Outdated Show resolved Hide resolved
Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying January 6, 2025 04:27
@ngjaying ngjaying merged commit 91fe83d into lf-edge:master Jan 6, 2025
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants