Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(io): support mqtt5 #3384

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat(io): support mqtt5 #3384

merged 1 commit into from
Nov 21, 2024

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Nov 20, 2024

Refactor to extract mqtt connection interface
Implement the interface for v4 and v5 separately
Fix subscription lock

Closes #1940

@ngjaying ngjaying force-pushed the mqtt5 branch 2 times, most recently from 3fcea6b to 4fdec4d Compare November 20, 2024 02:03
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 84 lines in your changes missing coverage. Please review.

Project coverage is 71.11%. Comparing base (410f52d) to head (c7b396c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/io/mqtt/v5client/client.go 59.43% 58 Missing and 13 partials ⚠️
internal/io/mqtt/v4client/client.go 91.46% 5 Missing and 2 partials ⚠️
internal/io/mqtt/conn.go 95.56% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3384      +/-   ##
==========================================
+ Coverage   71.08%   71.11%   +0.03%     
==========================================
  Files         403      405       +2     
  Lines       46080    46321     +241     
==========================================
+ Hits        32754    32938     +184     
- Misses      10753    10800      +47     
- Partials     2573     2583      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ngjaying ngjaying force-pushed the mqtt5 branch 4 times, most recently from 5e51237 to 5d7f000 Compare November 20, 2024 06:14
Refactor to extract mqtt connection interface
Implement the interface for v4 and v5 separately
Fix subscription lock

Signed-off-by: Jiyong Huang <[email protected]>
@ngjaying ngjaying marked this pull request as ready for review November 20, 2024 07:41
@ngjaying ngjaying requested a review from Yisaer November 20, 2024 07:41
@ngjaying ngjaying merged commit 56df9c5 into lf-edge:master Nov 21, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT5 support
2 participants