Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planner): clean subtopo when creation fail #3383

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 19, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.13%. Comparing base (dbce32d) to head (de8a16f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/planner/planner_source.go 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3383      +/-   ##
==========================================
- Coverage   71.19%   71.13%   -0.06%     
==========================================
  Files         403      403              
  Lines       45814    46080     +266     
==========================================
+ Hits        32617    32779     +162     
- Misses      10638    10734      +96     
- Partials     2559     2567       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ngjaying ngjaying changed the title fix: fix srcTopo fix(planner): clean subtopo when creation fail Nov 19, 2024
@ngjaying ngjaying merged commit 410f52d into lf-edge:master Nov 19, 2024
61 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Nov 22, 2024
ngjaying pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants