Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support wait sink node close #3373

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 12, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.39%. Comparing base (bfbb96d) to head (ec722ba).
Report is 1 commits behind head on master-1.14.

Files with missing lines Patch % Lines
internal/topo/node/sink_node.go 77.78% 4 Missing and 2 partials ⚠️
internal/topo/topo.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           master-1.14    #3373      +/-   ##
===============================================
+ Coverage        63.37%   63.39%   +0.01%     
===============================================
  Files              354      354              
  Lines            40740    40772      +32     
===============================================
+ Hits             25818    25844      +26     
  Misses           12672    12672              
- Partials          2250     2256       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer marked this pull request as ready for review November 12, 2024 05:20
@Yisaer Yisaer requested a review from ngjaying November 12, 2024 05:20
@ngjaying ngjaying merged commit 3d23ce4 into lf-edge:master-1.14 Nov 13, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants