Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support trace strategy #3284

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat: support trace strategy #3284

merged 3 commits into from
Oct 11, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Oct 11, 2024

support trace strategy head/always

  1. head will check whether the source request has trace parent if enabled
  2. alwayswill always trace if enabled

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 51.72414% with 56 lines in your changes missing coverage. Please review.

Project coverage is 70.95%. Comparing base (58bb2c2) to head (7fa4b1f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/topo/node/tracenode/trace_node.go 42.22% 23 Missing and 3 partials ⚠️
internal/server/rule_init.go 0.00% 10 Missing ⚠️
internal/topo/node/operations.go 0.00% 7 Missing ⚠️
internal/topo/node/batch_op.go 28.57% 4 Missing and 1 partial ⚠️
internal/server/rest.go 60.00% 3 Missing and 1 partial ⚠️
internal/topo/context/default.go 86.36% 3 Missing ⚠️
internal/topo/node/transform_op.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
+ Coverage   70.92%   70.95%   +0.03%     
==========================================
  Files         397      397              
  Lines       44631    44701      +70     
==========================================
+ Hits        31652    31716      +64     
- Misses      10464    10471       +7     
+ Partials     2515     2514       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need docs for strategy setting.

internal/io/neuron/sink.go Show resolved Hide resolved
Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying October 11, 2024 07:37
@ngjaying ngjaying merged commit f1ee479 into lf-edge:master Oct 11, 2024
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants