feat: support cpu profile api #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Song Gao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3279 +/- ##
==========================================
- Coverage 70.53% 70.51% -0.01%
==========================================
Files 400 400
Lines 45064 45086 +22
==========================================
+ Hits 31782 31791 +9
- Misses 10742 10755 +13
Partials 2540 2540 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
ngjaying
approved these changes
Oct 10, 2024
Signed-off-by: Song Gao <[email protected]>
ngjaying
requested changes
Oct 11, 2024
| @@ -80,6 +80,10 @@ After version 2.0.0, we added connection-related metrics for source/sink. | |||
|
|
|||
| The numeric types of these metrics can all be monitored using Prometheus. In the next section we will describe how to configure the Prometheus service in eKuiper. | |||
|
|
|||
| View CPU running metrics for a rule | |||
|
|
|||
| - kuiper_rule_cpuUsage: The CPU running indicator of the rule represents the CPU time used by the CPU in the past 30 seconds, in ms. | |||
There was a problem hiding this comment.
Is it better to comply with the metrics naming pattern (https://prometheus.io/docs/practices/naming/): kuiper_rule_cpu_ms?
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
ngjaying
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.