build: Dockerfile-alpine-python and Makefile build #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rory-Z
reviewed
Oct 8, 2024
|
And please update |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3271 +/- ##
==========================================
+ Coverage 70.80% 70.96% +0.16%
==========================================
Files 396 396
Lines 44524 44604 +80
==========================================
+ Hits 31524 31652 +128
+ Misses 10492 10436 -56
- Partials 2508 2516 +8 ☔ View full report in Codecov by Sentry. |
|
@vkaramanis Thanks. Please also sign-off your commit, following this link https://github.com/lf-edge/ekuiper/pull/3271/checks?check_run_id=31035835843 |
vkaramanis
force-pushed
the
dockerfile-alpine-python
branch
from
33745f7 to
a49cf13
Compare
Signed-off-by: Viktor Karamanis <[email protected]>
Co-authored-by: Rory <[email protected]> Signed-off-by: Viktor Karamanis <[email protected]>
vkaramanis
force-pushed
the
dockerfile-alpine-python
branch
from
a49cf13 to
ccc7537
Compare
Signed-off-by: Viktor Karamanis <[email protected]>
ngjaying
changed the title
Rory-Z
approved these changes
Oct 9, 2024
ngjaying
pushed a commit
to ngjaying/kuiper
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Viktor Karamanis <[email protected]> Co-authored-by: Vrump <[email protected]> Co-authored-by: Rory <[email protected]>
ngjaying
pushed a commit
to ngjaying/kuiper
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Viktor Karamanis <[email protected]> Co-authored-by: Vrump <[email protected]> Co-authored-by: Rory <[email protected]>
ngjaying
pushed a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Viktor Karamanis <[email protected]> Co-authored-by: Vrump <[email protected]> Co-authored-by: Rory <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When running Edgex in secure mode it uses securitty-bootstrapper which has been compiled in Alpine Linux.
Thus, using any other docker image than ekuiper-alpine fails because it cannot run the aforementioned binary.
Suggested solution:
Make a eKuiper python Alpine based docker image to be able to use python based plugins
Tests:
Tested and running successfully using ekuiper v1.14.4