Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sql prepare and html response escape #3245

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Sep 27, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 21 lines in your changes missing coverage. Please review.

Project coverage is 70.81%. Comparing base (b898083) to head (46cb208).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/server/schema_init.go 33.33% 9 Missing and 1 partial ⚠️
internal/pkg/store/sql/sqlTs.go 45.45% 4 Missing and 2 partials ⚠️
internal/pkg/store/sql/sqlKv.go 40.00% 2 Missing and 1 partial ⚠️
internal/server/rest.go 66.67% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3245      +/-   ##
==========================================
- Coverage   70.85%   70.81%   -0.04%     
==========================================
  Files         395      395              
  Lines       44335    44360      +25     
==========================================
+ Hits        31411    31412       +1     
- Misses      10430    10450      +20     
- Partials     2494     2498       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer requested a review from ngjaying September 27, 2024 06:57
@ngjaying ngjaying changed the title fix: fix security issue fix: sql statement prepare Sep 29, 2024
@ngjaying ngjaying changed the title fix: sql statement prepare fix: sql prepare and html response escape Sep 29, 2024
@ngjaying ngjaying merged commit 26280d6 into lf-edge:master Sep 29, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants