fix: fix cast security issue #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3243 +/- ##
==========================================
- Coverage 70.85% 70.74% -0.11%
==========================================
Files 395 395
Lines 44335 44424 +89
==========================================
+ Hits 31411 31427 +16
- Misses 10430 10488 +58
- Partials 2494 2509 +15 ☔ View full report in Codecov by Sentry. |
ngjaying
reviewed
Sep 29, 2024
| @@ -122,6 +126,9 @@ func (fc *FieldConverter) EncodeField(field *desc.FieldDescriptor, v interface{} | |||
| if err != nil { | |||
| return 0, nil | |||
| } else { | |||
| if r > math.MaxUint32 { | |||
| return 0, fmt.Errorf("value %d is out of uint32 range", v) | |||
| @@ -174,6 +181,9 @@ func (fc *FieldConverter) encodeSingleField(field *desc.FieldDescriptor, v inter | |||
| case dpb.FieldDescriptorProto_TYPE_INT32, dpb.FieldDescriptorProto_TYPE_SFIXED32, dpb.FieldDescriptorProto_TYPE_SINT32, dpb.FieldDescriptorProto_TYPE_ENUM: | |||
| r, err := cast.ToInt(v, cast.CONVERT_SAMEKIND) | |||
| if err == nil { | |||
| if r > math.MaxInt32 { | |||
| return 0, fmt.Errorf("value %d is out of int32 range", v) | |||
| @@ -188,6 +198,9 @@ func (fc *FieldConverter) encodeSingleField(field *desc.FieldDescriptor, v inter | |||
| case dpb.FieldDescriptorProto_TYPE_FIXED32, dpb.FieldDescriptorProto_TYPE_UINT32: | |||
| r, err := cast.ToUint64(v, cast.CONVERT_SAMEKIND) | |||
| if err == nil { | |||
| if r > math.MaxUint32 { | |||
| return 0, fmt.Errorf("value %d is out of uint32 range", v) | |||
Signed-off-by: Song Gao <[email protected]>
ngjaying
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.